linux-kernel - Re: [PATCH] erofs: get rid of erofs_kmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1da1e6c-0587-44cf-8107-4917a7a60d46@linux.alibaba.com>
Date: Mon, 17 Feb 2025 17:26:35 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Bo Liu <liubo03@...pur.com>, xiang@...nel.org, chao@...nel.org
Cc: linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] erofs: get rid of erofs_kmap_type



On 2025/2/17 17:10, Bo Liu wrote:
> Since EROFS_KMAP_ATOMIC is no longer valid, get rid of erofs_kmap_type too.
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>
> ---
>   fs/erofs/data.c     | 16 ++++++++--------
>   fs/erofs/dir.c      |  2 +-
>   fs/erofs/fileio.c   |  2 +-
>   fs/erofs/fscache.c  |  2 +-
>   fs/erofs/inode.c    |  6 +++---
>   fs/erofs/internal.h | 10 ++--------
>   fs/erofs/namei.c    |  2 +-
>   fs/erofs/super.c    |  8 ++++----
>   fs/erofs/xattr.c    | 12 ++++++------
>   fs/erofs/zdata.c    |  4 ++--
>   fs/erofs/zmap.c     |  6 +++---
>   11 files changed, 32 insertions(+), 38 deletions(-)
> 
> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index 0cd6b5c4df98..386e312de8c0 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -26,7 +26,7 @@ void erofs_put_metabuf(struct erofs_buf *buf)
>   }
>   
>   void *erofs_bread(struct erofs_buf *buf, erofs_off_t offset,
> -		  enum erofs_kmap_type type)
> +				bool need_kmap)

leave in the same line?

Otherwise it looks good to me.

Thanks,
Gao Xiang