linux-kernel - Re: [PATCH 1/2] usb: core: Don't use %pK through printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025021733-strudel-curator-bfaf@gregkh>
Date: Mon, 17 Feb 2025 14:52:05 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Patrice Chotard <patrice.chotard@...s.st.com>,
	Thinh Nguyen <Thinh.Nguyen@...opsys.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] usb: core: Don't use %pK through printk

On Mon, Feb 17, 2025 at 02:20:51PM +0100, Thomas Weißschuh wrote:
> Restricted pointers ("%pK") are not meant to be used through printk().
> It can unintentionally expose security sensitive, raw pointer values.
> 
> Use regular pointer formatting instead.
> 
> Link: https://lore.kernel.org/lkml/20250113171731-dc10e3c1-da64-4af0-b767-7c7070468023@linutronix.de/
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

So really this is just a revert of 2f964780c03b ("USB: core: replace %p
with %pK"), right?

Why not express it that way, and explain _why_ it's somehow now ok to
use %p when previously it wasn't?

thanks,

greg k-h