linux-kernel - Re: [PATCH v2 13/29] ASoC: tas2770: Export 'die

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7Slq3BQY7S5REPy@finisterre.sirena.org.uk>
Date: Tue, 18 Feb 2025 15:22:19 +0000
From: Mark Brown <broonie@...nel.org>
To: James Calligeros <jcalligeros99@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Shenghao Ding <shenghao-ding@...com>,
	Kevin Lu <kevin-lu@...com>, Baojun Xu <baojun.xu@...com>,
	Dan Murphy <dmurphy@...com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Shi Fu <shifu0704@...ndersoft.com>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Alyssa Rosenzweig <alyssa@...enzweig.io>,
	Martin Povišer <povik+lin@...ebit.org>,
	Hector Martin <marcan@...can.st>, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	asahi@...ts.linux.dev, linux-hwmon@...r.kernel.org,
	Neal Gompa <neal@...pa.dev>
Subject: Re: [PATCH v2 13/29] ASoC: tas2770: Export 'die_temp' to sysfs

On Tue, Feb 18, 2025 at 06:35:47PM +1000, James Calligeros wrote:
> From: Martin Povišer <povik+lin@...ebit.org>
> 
> Export a file for the readout of die temperature measurements.
> As per the datasheet, the temperature can be calculated by
> dividing the register value by 16 and then subtracting 93.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)