linux-kernel - Re: [PATCH 1/1] x86/vmemmap: Use direct-mapped VA instead of vmemmap-based VA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250217214342.33b4fcc4e775cf5ca70053a0@linux-foundation.org>
Date: Mon, 17 Feb 2025 21:43:42 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Harry Yoo (Oracle)" <42.hyeyoo@...il.com>
Cc: Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>,
 linux-kernel@...r.kernel.org, osalvador@...e.de, byungchul@...com,
 dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
 max.byungchul.park@...com, max.byungchul.park@...il.com
Subject: Re: [PATCH 1/1] x86/vmemmap: Use direct-mapped VA instead of
 vmemmap-based VA

On Tue, 18 Feb 2025 14:27:27 +0900 "Harry Yoo (Oracle)" <42.hyeyoo@...il.com> wrote:

> > page table when accessing a vmemmap-based virtual address before this sync.
> > 
> > Fixes: faf1c0008a33 ("x86/vmemmap: optimize for consecutive sections in partial populated PMDs")
> > Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>
> > Cc: Oscar Salvador <osalvador@...e.de>
> > Cc: Hyeonggon Yoo <42.hyeyoo@...il.com>
> 
> I think this fix is reasonable without changing existing code too much.
> Any thoughts from x86 folks?
> 
> > Cc: Byungchul Park <byungchul@...com>
> > Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> > Cc: Andy Lutomirski <luto@...nel.org>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> 
> Shouldn't we add Cc: <stable@...r.kernel.org>?

I'd say so, yes.  For many subsystems, a Fixes: means that -stable
maintainers will automatically scoop it up.  For mm patches they have
been asked to not do that - such patches require an explicit cc:stable
(the MM developers wish to determine what is backported).

An explicit cc:stable removes all doubt.

Also, this patch should have cc'ed linux-mm, please.

Anyway, I'll grab it pending additional review and I'll add the
cc:stable, thanks.