linux-kernel - Re: [PATCH 1/1] x86/vmemmap: Use direct-mapped VA instead of vmemmap-based VA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06eff380-a386-44d1-9115-33a08c2d8c95@intel.com>
Date: Tue, 18 Feb 2025 12:02:11 +0200
From: Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>
To: Andrew Morton <akpm@...ux-foundation.org>, "Harry Yoo (Oracle)"
	<42.hyeyoo@...il.com>
CC: <linux-kernel@...r.kernel.org>, <osalvador@...e.de>, <byungchul@...com>,
	<dave.hansen@...ux.intel.com>, <luto@...nel.org>, <peterz@...radead.org>,
	<max.byungchul.park@...com>, <max.byungchul.park@...il.com>
Subject: Re: [PATCH 1/1] x86/vmemmap: Use direct-mapped VA instead of
 vmemmap-based VA



On 2/18/25 7:43 AM, Andrew Morton wrote:
> On Tue, 18 Feb 2025 14:27:27 +0900 "Harry Yoo (Oracle)" <42.hyeyoo@...il.com> wrote:
> 
>>> page table when accessing a vmemmap-based virtual address before this sync.
>>>
>>> Fixes: faf1c0008a33 ("x86/vmemmap: optimize for consecutive sections in partial populated PMDs")
>>> Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>
>>> Cc: Oscar Salvador <osalvador@...e.de>
>>> Cc: Hyeonggon Yoo <42.hyeyoo@...il.com>
>>
>> I think this fix is reasonable without changing existing code too much.
>> Any thoughts from x86 folks?
>>
>>> Cc: Byungchul Park <byungchul@...com>
>>> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
>>> Cc: Andy Lutomirski <luto@...nel.org>
>>> Cc: Peter Zijlstra <peterz@...radead.org>
>>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>>
>> Shouldn't we add Cc: <stable@...r.kernel.org>?
> 
@Harry, I missed cc'ing stable mailinglist, thanks for point-out.
> I'd say so, yes.  For many subsystems, a Fixes: means that -stable
> maintainers will automatically scoop it up.  For mm patches they have
> been asked to not do that - such patches require an explicit cc:stable
> (the MM developers wish to determine what is backported).
> 
> An explicit cc:stable removes all doubt.
> 
> Also, this patch should have cc'ed linux-mm, please.
> 
@Andrew Morton Cc'ing linux-mm is also something I missed. Thanks for 
the mention.
And thanks for the explaition of the fixes on mm patches.
> Anyway, I'll grab it pending additional review and I'll add the
> cc:stable, thanks.
> 
Thanks for the review.

G.G.