linux-kernel - Re: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04553pqn-2s4r-593r-q8pq-4s18q5380p9n@xreary.bet>
Date: Tue, 18 Feb 2025 22:10:16 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Even Xu <even.xu@...el.com>
cc: david.laight.linux@...il.com, bentiss@...nel.org, 
    srinivas.pandruvada@...ux.intel.com, mpearson-lenovo@...ebb.ca, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
    kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y"
 issue

On Thu, 13 Feb 2025, Even Xu wrote:

> Change to use "||" to make it more readable and avoid miss
> understanding.
> 
> Signed-off-by: Even Xu <even.xu@...el.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501292144.eFDq4ovr-lkp@intel.com
> ---
>  drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> index eb23bea77686..8f97e71df7f4 100644
> --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> @@ -295,7 +295,7 @@ static void release_dma_buffers(struct thc_device *dev,
>  		return;
>  
>  	for (i = 0; i < config->prd_tbl_num; i++) {
> -		if (!config->sgls[i] | !config->sgls_nent[i])
> +		if (!config->sgls[i] || !config->sgls_nent[i])
>  			continue;

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs