linux-kernel - RE: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB609867E0BE78125CF48E99B8F4C52@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Wed, 19 Feb 2025 00:49:22 +0000
From: "Xu, Even" <even.xu@...el.com>
To: Jiri Kosina <jikos@...nel.org>
CC: "david.laight.linux@...il.com" <david.laight.linux@...il.com>,
	"bentiss@...nel.org" <bentiss@...nel.org>,
	"srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
	"mpearson-lenovo@...ebb.ca" <mpearson-lenovo@...ebb.ca>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, lkp
	<lkp@...el.com>
Subject: RE: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y"
 issue

Thanks Jiri!

Best Regards,
Even Xu

> -----Original Message-----
> From: Jiri Kosina <jikos@...nel.org>
> Sent: Wednesday, February 19, 2025 5:10 AM
> To: Xu, Even <even.xu@...el.com>
> Cc: david.laight.linux@...il.com; bentiss@...nel.org;
> srinivas.pandruvada@...ux.intel.com; mpearson-lenovo@...ebb.ca; linux-
> input@...r.kernel.org; linux-kernel@...r.kernel.org; lkp <lkp@...el.com>
> Subject: Re: [PATCH] Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue
> 
> On Thu, 13 Feb 2025, Even Xu wrote:
> 
> > Change to use "||" to make it more readable and avoid miss
> > understanding.
> >
> > Signed-off-by: Even Xu <even.xu@...el.com>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202501292144.eFDq4ovr-lkp@intel.
> > com
> > ---
> >  drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> > b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> > index eb23bea77686..8f97e71df7f4 100644
> > --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> > +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c
> > @@ -295,7 +295,7 @@ static void release_dma_buffers(struct thc_device
> *dev,
> >  		return;
> >
> >  	for (i = 0; i < config->prd_tbl_num; i++) {
> > -		if (!config->sgls[i] | !config->sgls_nent[i])
> > +		if (!config->sgls[i] || !config->sgls_nent[i])
> >  			continue;
> 
> Applied, thanks.
> 
> --
> Jiri Kosina
> SUSE Labs