linux-kernel - Re: [PATCH v2 4/6] vfio/type1: Use consistent types for page counts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHTA-ubd8eTAt41n41jTR-O6PH+aVMvufghtYCja5xv3DwC+nA@mail.gmail.com>
Date: Tue, 18 Feb 2025 18:55:06 -0600
From: Mitchell Augustin <mitchell.augustin@...onical.com>
To: Peter Xu <peterx@...hat.com>
Cc: Alex Williamson <alex.williamson@...hat.com>, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, clg@...hat.com, jgg@...dia.com
Subject: Re: [PATCH v2 4/6] vfio/type1: Use consistent types for page counts

No change in behavior observed from v1 on my config (DGX H100). Thanks!

Reviewed-by: "Mitchell Augustin" <mitchell.augustin@...onical.com>
Tested-by: "Mitchell Augustin" <mitchell.augustin@...onical.com>

On Tue, Feb 18, 2025 at 4:46 PM Peter Xu <peterx@...hat.com> wrote:
>
> On Tue, Feb 18, 2025 at 03:22:04PM -0700, Alex Williamson wrote:
> > Page count should more consistently be an unsigned long when passed as
> > an argument while functions returning a number of pages should use a
> > signed long to allow for -errno.
> >
> > vaddr_get_pfns() can therefore be upgraded to return long, though in
> > practice it's currently limited by the batch capacity.  In fact, the
> > batch indexes are noted to never hold negative values, so while it
> > doesn't make sense to bloat the structure with unsigned longs in this
> > case, it does make sense to specify these as unsigned.
> >
> > No change in behavior expected.
> >
> > Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
>
> Reviewed-by: Peter Xu <peterx@...hat.com>
>
> --
> Peter Xu
>


-- 
Mitchell Augustin
Software Engineer - Ubuntu Partner Engineering