linux-kernel - Re: [PATCH v2 13/15] arm64: dts: imx8mm-phycore-som: Add overlay for rproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1804102d-22ed-40f2-ad0c-8949f205461f@norik.com>
Date: Tue, 18 Feb 2025 06:16:47 +0100
From: Andrej Picej <andrej.picej@...ik.com>
To: Shawn Guo <shawnguo2@...h.net>
Cc: shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
 festevam@...il.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, upstream@...ts.phytec.de
Subject: Re: [PATCH v2 13/15] arm64: dts: imx8mm-phycore-som: Add overlay for
 rproc



On 17. 02. 25 11:11, Shawn Guo wrote:
> On Tue, Dec 31, 2024 at 08:34:32AM +0100, Andrej Picej wrote:
>>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso
>>>> new file mode 100644
>>>> index 000000000000..0c61946f0cf8
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso
>>>> @@ -0,0 +1,55 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +/*
>>>> + * Copyright (C) 2024 PHYTEC Messtechnik GmbH
>>>> + * Author: Dominik Haller <d.haller@...tec.de>
>>>> + */
>>>> +
>>>> +/dts-v1/;
>>>> +/plugin/;
>>>> +
>>>> +#include <dt-bindings/clock/imx8mm-clock.h>
>>>> +
>>>> +&{/} {
>>>> +	reserved-memory {
>>>> +		#address-cells = <2>;
>>>> +		#size-cells = <2>;
>>>> +		ranges;
>>>
>>> I'm getting this:
>>>
>>> arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:16.3-10: Warning (ranges_format): /fragment@..._overlay__/reserved-memory:ranges: empty "ranges" property but its #size-cells (2) differs from /fragment@..._overlay__ (1)
>>> arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:13.18-43.4: Warning (avoid_default_addr_size): /fragment@..._overlay__/reserved-memory: Relying on default #address-cells value
>>> arch/arm64/boot/dts/freescale/imx8mm-phycore-rpmsg.dtso:13.18-43.4: Warning (avoid_default_addr_size): /fragment@..._overlay__/reserved-memory: Relying on default #size-cells value
>>>
>>
>> I see, missed this before, sorry. But I have some problems fixing it.
>> I think the problem is that this is overlay, the same node put in the
>> imx8mm-phycore-som.dtsi doesn't trigger a warning.
>> The only solution that I found is that I specify the default address-cells
>> and size-cells in root node:
>>
>>
>> &{/} {
>> 	#address-cells = <2>;
>> 	#size-cells = <2>;
>>
>> 	reserved-memory {
>> 		#address-cells = <2>;
>> 		#size-cells = <2>;
>> 		ranges;
>> 	...
>> 	};
>> };
>>
>> The same values are used in imx8mm.dtsi, but the checker fails to find these
>> default values.
>> Not sure if this is the right solution, though. Your input would be helpful,
>> thanks.
> 
> Unless DT folks have better suggestion, I'm fine with this.

Ok, I'll send a v2. Thanks.

Best regards,
Andrej

> 
> Shawn
>