linux-kernel - Re: [PATCH] ntsync: Set the permissions to be 0666

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2768333.mvXUDI8C0e@camazotz>
Date: Tue, 18 Feb 2025 17:57:31 -0600
From: Elizabeth Figura <zfigura@...eweavers.com>
To: dri-devel@...ts.freedesktop.org, Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>,
 Mike Lothian <mike@...eburn.co.uk>
Cc: Mike Lothian <mike@...eburn.co.uk>, linux-kernel@...r.kernel.org,
 linux-api@...r.kernel.org, wine-devel@...ehq.org,
 André Almeida <andrealmeid@...lia.com>,
 Wolfram Sang <wsa@...nel.org>, Arkadiusz Hiler <ahiler@...eweavers.com>,
 Peter Zijlstra <peterz@...radead.org>, Andy Lutomirski <luto@...nel.org>,
 Randy Dunlap <rdunlap@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Will Deacon <will@...nel.org>, Waiman Long <longman@...hat.com>,
 Boqun Feng <boqun.feng@...il.com>
Subject: Re: [PATCH] ntsync: Set the permissions to be 0666

On Friday, 14 February 2025 06:28:00 CST Mike Lothian wrote:
> This allows ntsync to be usuable by non-root processes out of the box
> 
> Signed-off-by: Mike Lothian <mike@...eburn.co.uk>
> ---
>  drivers/misc/ntsync.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
> index 055395cde42b..586b86243e1d 100644
> --- a/drivers/misc/ntsync.c
> +++ b/drivers/misc/ntsync.c
> @@ -1208,6 +1208,7 @@ static struct miscdevice ntsync_misc = {
>  	.minor		= MISC_DYNAMIC_MINOR,
>  	.name		= NTSYNC_NAME,
>  	.fops		= &ntsync_fops,
> +	.mode		= 0666, // Setting file permissions to 0666
>  };
>  
>  module_misc_device(ntsync_misc);
> 

Reviewed-by: Elizabeth Figura <zfigura@...eweavers.com>

--

The comment seems rather redundant, but otherwise this is correct and prudent.