linux-kernel - Re: [PATCH] ntsync: Set the permissions to be 0666

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025021933-sureness-tipped-ff2b@gregkh>
Date: Wed, 19 Feb 2025 15:22:46 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Elizabeth Figura <zfigura@...eweavers.com>
Cc: dri-devel@...ts.freedesktop.org, Arnd Bergmann <arnd@...db.de>,
	Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>,
	Mike Lothian <mike@...eburn.co.uk>, linux-kernel@...r.kernel.org,
	linux-api@...r.kernel.org, wine-devel@...ehq.org,
	André Almeida <andrealmeid@...lia.com>,
	Wolfram Sang <wsa@...nel.org>,
	Arkadiusz Hiler <ahiler@...eweavers.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...nel.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
	Waiman Long <longman@...hat.com>, Boqun Feng <boqun.feng@...il.com>
Subject: Re: [PATCH] ntsync: Set the permissions to be 0666

On Tue, Feb 18, 2025 at 05:57:31PM -0600, Elizabeth Figura wrote:
> On Friday, 14 February 2025 06:28:00 CST Mike Lothian wrote:
> > This allows ntsync to be usuable by non-root processes out of the box
> > 
> > Signed-off-by: Mike Lothian <mike@...eburn.co.uk>
> > ---
> >  drivers/misc/ntsync.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
> > index 055395cde42b..586b86243e1d 100644
> > --- a/drivers/misc/ntsync.c
> > +++ b/drivers/misc/ntsync.c
> > @@ -1208,6 +1208,7 @@ static struct miscdevice ntsync_misc = {
> >  	.minor		= MISC_DYNAMIC_MINOR,
> >  	.name		= NTSYNC_NAME,
> >  	.fops		= &ntsync_fops,
> > +	.mode		= 0666, // Setting file permissions to 0666
> >  };
> >  
> >  module_misc_device(ntsync_misc);
> > 
> 
> Reviewed-by: Elizabeth Figura <zfigura@...eweavers.com>
> 
> --
> 
> The comment seems rather redundant, but otherwise this is correct and prudent.

I agree, I'll drop the comment when I apply it, thanks.

greg k-h