linux-kernel - RE: [PATCH v2 04/16] x86/mce/amd: Put list_head in threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134FEB75F14FF772827AE8C89FA2@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Tue, 18 Feb 2025 01:28:02 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Yazen Ghannam <yazen.ghannam@....com>, "x86@...nel.org" <x86@...nel.org>,
	"Luck, Tony" <tony.luck@...el.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Smita.KoralahalliChannabasappa@....com"
	<Smita.KoralahalliChannabasappa@....com>
Subject: RE: [PATCH v2 04/16] x86/mce/amd: Put list_head in threshold_bank

> From: Yazen Ghannam <yazen.ghannam@....com>
> Sent: Friday, February 14, 2025 12:46 AM
> To: x86@...nel.org; Luck, Tony <tony.luck@...el.com>
> Cc: linux-kernel@...r.kernel.org; linux-edac@...r.kernel.org;
> Smita.KoralahalliChannabasappa@....com; Yazen Ghannam
> <yazen.ghannam@....com>
> Subject: [PATCH v2 04/16] x86/mce/amd: Put list_head in threshold_bank
> 
> The threshold_bank structure is a container for one or more threshold_block
> structures. Currently, the container has a single pointer to the 'first'
> threshold_block structure which then has a linked list of the remaining
> threshold_block structures.
> 
> This results in an extra level of indirection where the 'first' block is checked
> before iterating over the remaining blocks.
> 
> Remove the indirection by including the head of the block list in the
> threshold_bank structure which already acts as a container for all the bank's
> thresholding blocks.
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>

Nice cleanup.

    Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>