linux-kernel - RE: [PATCH v2 05/16] x86/mce: Cleanup bank processing on init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134F3A98FA99C05ECC5F57689FA2@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Tue, 18 Feb 2025 02:15:28 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Yazen Ghannam <yazen.ghannam@....com>, "x86@...nel.org" <x86@...nel.org>,
	"Luck, Tony" <tony.luck@...el.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Smita.KoralahalliChannabasappa@....com"
	<Smita.KoralahalliChannabasappa@....com>
Subject: RE: [PATCH v2 05/16] x86/mce: Cleanup bank processing on init

> From: Yazen Ghannam <yazen.ghannam@....com>
> Sent: Friday, February 14, 2025 12:46 AM
> To: x86@...nel.org; Luck, Tony <tony.luck@...el.com>
> Cc: linux-kernel@...r.kernel.org; linux-edac@...r.kernel.org;
> Smita.KoralahalliChannabasappa@....com; Yazen Ghannam
> <yazen.ghannam@....com>
> Subject: [PATCH v2 05/16] x86/mce: Cleanup bank processing on init
> 
> From: Borislav Petkov <bp@...e.de>
> 
> Unify the bank preparation into __mcheck_cpu_init_clear_banks(), rename
> that function to what it does now - prepares banks. Do this so that generic
> and vendor banks init goes first so that settings done during that init can take
> effect before the first bank polling takes place.
> 
> Move __mcheck_cpu_check_banks() into
> __mcheck_cpu_init_prepare_banks() as it already loops over the banks.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Reviewed-by: Yazen Ghannam <yazen.ghannam@....com>

Other than Tony's comments about the missing comment for 
'MCP_DONTLOG',

    Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>