linux-kernel - Re: [PATCH v5 1/2] vfs: export invalidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ze23goaoxiryaczmik3y66p23c35tf3ipfw27prlozrqciqlap@6lmpmsx7xsy3>
Date: Tue, 18 Feb 2025 12:59:37 +0100
From: Jan Kara <jack@...e.cz>
To: Luis Henriques <luis@...lia.com>
Cc: Miklos Szeredi <miklos@...redi.hu>, Bernd Schubert <bschubert@....com>, 
	Dave Chinner <david@...morbit.com>, Alexander Viro <viro@...iv.linux.org.uk>, 
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, Matt Harvey <mharvey@...ptrading.com>, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] vfs: export invalidate_inodes()

On Sun 16-02-25 16:50:07, Luis Henriques wrote:
> Signed-off-by: Luis Henriques <luis@...lia.com>

Please use evict_inodes(). It is already exported and does exactly the same
these days. We should really merge the patch deleting invalidate_inodes()
:)

									Honza

> ---
>  fs/inode.c         | 1 +
>  fs/internal.h      | 1 -
>  include/linux/fs.h | 1 +
>  3 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/inode.c b/fs/inode.c
> index 5587aabdaa5e..88387ecb2c34 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -939,6 +939,7 @@ void invalidate_inodes(struct super_block *sb)
>  
>  	dispose_list(&dispose);
>  }
> +EXPORT_SYMBOL(invalidate_inodes);
>  
>  /*
>   * Isolate the inode from the LRU in preparation for freeing it.
> diff --git a/fs/internal.h b/fs/internal.h
> index e7f02ae1e098..7cb515cede3f 100644
> --- a/fs/internal.h
> +++ b/fs/internal.h
> @@ -207,7 +207,6 @@ bool in_group_or_capable(struct mnt_idmap *idmap,
>   * fs-writeback.c
>   */
>  extern long get_nr_dirty_inodes(void);
> -void invalidate_inodes(struct super_block *sb);
>  
>  /*
>   * dcache.c
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 2c3b2f8a621f..ff016885646e 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -3270,6 +3270,7 @@ extern void discard_new_inode(struct inode *);
>  extern unsigned int get_next_ino(void);
>  extern void evict_inodes(struct super_block *sb);
>  void dump_mapping(const struct address_space *);
> +extern void invalidate_inodes(struct super_block *sb);
>  
>  /*
>   * Userspace may rely on the inode number being non-zero. For example, glibc
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR