lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPhsuW7z=rQoGRmWaEihtmxb=QNcuiM8aTgtaR0wZ6G049YjkQ@mail.gmail.com>
Date: Wed, 19 Feb 2025 09:41:21 -0800
From: Song Liu <song@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
	"H. Peter Anvin" <hpa@...or.com>, "Mike Rapoport (Microsoft)" <rppt@...nel.org>, Peter Zijlstra <peterz@...radead.org>, 
	Luis Chamberlain <mcgrof@...nel.org>, Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] x86/module: remove unnecessary check in module_finalize()

On Wed, Feb 19, 2025 at 5:48 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The "calls" pointer can no longer be NULL after commit ab9fea59487d
> ("x86/alternative: Simplify callthunk patching") was merged.  Delete
> this unnecessary check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Acked-by: Song Liu <song@...nel.org>

> ---
>  arch/x86/kernel/module.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c
> index cb9d295e67cb..615f74c4bd6c 100644
> --- a/arch/x86/kernel/module.c
> +++ b/arch/x86/kernel/module.c
> @@ -278,10 +278,8 @@ int module_finalize(const Elf_Ehdr *hdr,
>         if (calls) {
>                 struct callthunk_sites cs = {};
>
> -               if (calls) {
> -                       cs.call_start = (void *)calls->sh_addr;
> -                       cs.call_end = (void *)calls->sh_addr + calls->sh_size;
> -               }
> +               cs.call_start = (void *)calls->sh_addr;
> +               cs.call_end = (void *)calls->sh_addr + calls->sh_size;
>
>                 callthunks_patch_module_calls(&cs, me);
>         }
> --
> 2.47.2
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ