linux-kernel - Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4f2ae439-1bdc-4593-9151-e15981509344@app.fastmail.com>
Date: Wed, 19 Feb 2025 07:47:06 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: oushixiong <oushixiong1025@....com>, "Helge Deller" <deller@....de>
Cc: "Thomas Zimmermann" <tzimmermann@...e.de>,
 "Laurent Pinchart" <laurent.pinchart+renesas@...asonboard.com>,
 "Lee Jones" <lee@...nel.org>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, oushixiong <oushixiong@...inos.cn>
Subject: Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove_file()

On Sat, Feb 8, 2025, at 10:29, oushixiong1025@....com wrote:
> From: Shixiong Ou <oushixiong@...inos.cn>
>
> 1. The device_remove_file() need to be called when driver is removing.
> 2. The device_remove_file() need to be called if the call to
>    device_create_file() fails.

This should probably use device_add_group() instead of
individual files to simplify both creation and removal.
It would also avoid the bug you introduced that gcc warns
about.

      Arnd