linux-kernel - Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <437a0a0e-f61d-45bf-b859-d527381a9763@163.com>
Date: Wed, 19 Feb 2025 15:40:24 +0800
From: Shixiong Ou <oushixiong1025@....com>
To: Arnd Bergmann <arnd@...db.de>, Helge Deller <deller@....de>
Cc: Thomas Zimmermann <tzimmermann@...e.de>,
 Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
 Lee Jones <lee@...nel.org>, Uwe Kleine-König
 <u.kleine-koenig@...libre.com>, linux-fbdev@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 oushixiong <oushixiong@...inos.cn>
Subject: Re: [PATCH v2] fbdev: lcdcfb: add missing device_remove_file()


在 2025/2/19 14:47, Arnd Bergmann 写道:
> On Sat, Feb 8, 2025, at 10:29, oushixiong1025@....com wrote:
>> From: Shixiong Ou <oushixiong@...inos.cn>
>>
>> 1. The device_remove_file() need to be called when driver is removing.
>> 2. The device_remove_file() need to be called if the call to
>>     device_create_file() fails.
> This should probably use device_add_group() instead of
> individual files to simplify both creation and removal.
> It would also avoid the bug you introduced that gcc warns
> about.
>
>        Arnd

Thank you for your suggestion. I will incorporate your advice and resend a patch.

Thanks and Regards,
Shixiong Ou.