[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z7XdIbYEqqjfLSsC@e133380.arm.com>
Date: Wed, 19 Feb 2025 13:31:13 +0000
From: Dave Martin <Dave.Martin@....com>
To: "Moger, Babu" <bmoger@....com>
Cc: Reinette Chatre <reinette.chatre@...el.com>,
Babu Moger <babu.moger@....com>, corbet@....net, tglx@...utronix.de,
mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
tony.luck@...el.com, peternewman@...gle.com, x86@...nel.org,
hpa@...or.com, paulmck@...nel.org, akpm@...ux-foundation.org,
thuth@...hat.com, rostedt@...dmis.org, xiongwei.song@...driver.com,
pawan.kumar.gupta@...ux.intel.com, daniel.sneddon@...ux.intel.com,
jpoimboe@...nel.org, perry.yuan@....com, sandipan.das@....com,
kai.huang@...el.com, xiaoyao.li@...el.com, seanjc@...gle.com,
xin3.li@...el.com, andrew.cooper3@...rix.com, ebiggers@...gle.com,
mario.limonciello@....com, james.morse@....com,
tan.shaopeng@...itsu.com, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, maciej.wieczor-retman@...el.com,
eranian@...gle.com
Subject: Re: [PATCH v11 12/23] x86/resctrl: Introduce interface to display
number of free counters
On Fri, Feb 07, 2025 at 12:59:55PM -0600, Moger, Babu wrote:
> Hi Reinette,
>
> On 2/5/2025 6:19 PM, Reinette Chatre wrote:
> > Hi Babu,
> >
> > On 1/22/25 12:20 PM, Babu Moger wrote:
[...]
> > > diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
> > > index 31ff764deeeb..99cae75559b0 100644
> > > --- a/Documentation/arch/x86/resctrl.rst
> > > +++ b/Documentation/arch/x86/resctrl.rst
> > > @@ -299,6 +299,14 @@ with the following files:
> > > memory bandwidth tracking to a single memory bandwidth event per
> > > monitoring group.
> > > +"available_mbm_cntrs":
> > > + The number of monitoring counters available for assignment in each
> > > + domain when mbm_cntr_assign mode is enabled on the system.
> > > + ::
> > > +
> >
> > Documentation jumps in with some hardcoded values that may cause confusion.
> > It looks to be missing something like (and looking back this also applies
> > to "num_mbm_cntrs"):
> > "For example, on a system with 30 available monitoring/(hardware?) counters in
> > each of its L3 domains:"
>
> Sure.
It could make sense to write something like
"... 30 available [hardware] memory bandwidth counters in each ..."
MPAM has different kinds of counters, at least in theory.
(No big deal, though.)
Cheers
---Dave
Powered by blists - more mailing lists