linux-kernel - Re: [PATCH 0/4] Add SDCA register map support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f0f70de-d3cf-4956-a5aa-c5bed91a61cf@linux.dev>
Date: Thu, 20 Feb 2025 07:01:44 -0600
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>
To: Charles Keepax <ckeepax@...nsource.cirrus.com>, broonie@...nel.org
Cc: lgirdwood@...il.com, peter.ujfalusi@...ux.intel.com,
 yung-chuan.liao@...ux.intel.com, linux-kernel@...r.kernel.org,
 linux-sound@...r.kernel.org
Subject: Re: [PATCH 0/4] Add SDCA register map support

On 2/17/25 08:01, Charles Keepax wrote:
> This series is the next step of adding SDCA support. Here we add
> helper functions to allow drivers to easily use the SDCA DisCo
> information to create a register map for the device.

Can you remind me where we ended-up in the discussion on one regmap per physical device or one regmap per function?

The DisCo definition are all function-centric, but the physical SoundWire bus access for all read/writes is shared by all functions so having a single regmap isn't silly either.

> The basic idea here is the code takes the list of SDCA controls parsed
> from DisCo and uses primarily the Access Mode to determine if the
> register should be marked as readable/writable etc. Further more
> some additional concepts such as DisCo Constants and Defaults are
> handled. There is some potential confusion, as DisCo Constants are
> handled as an entry in the regmap defaults table, whereas a DisCo
> Default is simply handled as a write to the register. Alas the naming
> confusion is an unavoidable result of the slight impedance mismatch
> between the two systems.
> 
> Thanks,
> Charles
> 
> Charles Keepax (4):
>   regcache: Add support for sorting defaults arrays
>   ASoC: SDCA: Add generic regmap SDCA helpers
>   ASoC: SDCA: Add regmap helpers for parsing for DisCo Constant values
>   ASoC: SDCA: Add helper to write out defaults and fixed values

The code looks fine, thanks!

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>

> 
>  drivers/base/regmap/regcache.c |  31 ++++
>  include/linux/regmap.h         |   7 +
>  include/sound/sdca_regmap.h    |  31 ++++
>  sound/soc/sdca/Makefile        |   2 +-
>  sound/soc/sdca/sdca_regmap.c   | 321 +++++++++++++++++++++++++++++++++
>  5 files changed, 391 insertions(+), 1 deletion(-)
>  create mode 100644 include/sound/sdca_regmap.h
>  create mode 100644 sound/soc/sdca/sdca_regmap.c
>