linux-kernel - Re: [PATCH v2 10/16] x86/mce: Separate global and per-CPU quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250220143721.GC589698@yaz-khff2.amd.com>
Date: Thu, 20 Feb 2025 09:37:21 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
Cc: "x86@...nel.org" <x86@...nel.org>, "Luck, Tony" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Smita.KoralahalliChannabasappa@....com" <Smita.KoralahalliChannabasappa@....com>
Subject: Re: [PATCH v2 10/16] x86/mce: Separate global and per-CPU quirks

On Thu, Feb 20, 2025 at 01:27:03AM +0000, Zhuo, Qiuxu wrote:
> > From: Yazen Ghannam <yazen.ghannam@....com>
> > [...]
> > > Is it better to add the following description here? So that it's clear
> > > we don't apply the quirks for older CPUs.
> > >
> > >     Older CPUs (prior to family 6) can't reach this point and already return
> > early
> > >     due to the check of __mcheck_cpu_ancient_init().
> > >
> > 
> > I don't know. As you said, the older CPUs don't enter this code, so why refer
> > to them at all?
> > 
> 
> As the following check "if (c->x86_vfm < INTEL_NEHALEM_EP ..." includes older 
> CPUs (e.g. family == 5). Stating that older CPUs don't reach this point makes it 
> clear that the quirks are not applied to them.
> 

Okay, that's fair.

Thanks,
Yazen