linux-kernel - Re: [PATCH v2 13/16] x86/mce: Unify AMD DFR handler with MCA Polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250220144101.GD589698@yaz-khff2.amd.com>
Date: Thu, 20 Feb 2025 09:41:01 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
Cc: "x86@...nel.org" <x86@...nel.org>, "Luck, Tony" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Smita.KoralahalliChannabasappa@....com" <Smita.KoralahalliChannabasappa@....com>
Subject: Re: [PATCH v2 13/16] x86/mce: Unify AMD DFR handler with MCA Polling

On Thu, Feb 20, 2025 at 01:41:21AM +0000, Zhuo, Qiuxu wrote:
> > From: Yazen Ghannam <yazen.ghannam@....com>
> > [...]
> > > Is the following check in machine_check_poll() needed before
> > > queuing/logging AMD's deferred error?
> > >
> > >        if (mca_cfg.dont_log_ce && !mce_usable_address(m))
> > >              //Just clear MCA_STATUS, but not queue/log errors.
> > >
> > 
> > Good question. Deferred errors are uncorrectable errors that don't need
> > immediate action. They are not correctable errors, so the 'dont_log_ce'
> > flag shouldn't apply.
> 
> Thanks for the explanation. 
> How about the 2nd check "mce_usable_address(m)"?
> 

It's not relevant. We want to always log deferred errors since they are
uncorrectable.

Thanks,
Yazen