linux-kernel - RE: [PATCH v2 07/16] x86/mce: Define BSP-only init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB71342BEF686D52AA3ED52B0789C02@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Mon, 24 Feb 2025 13:28:23 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Yazen Ghannam <yazen.ghannam@....com>
CC: "x86@...nel.org" <x86@...nel.org>, "Luck, Tony" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Smita.KoralahalliChannabasappa@....com"
	<Smita.KoralahalliChannabasappa@....com>
Subject: RE: [PATCH v2 07/16] x86/mce: Define BSP-only init

> From: Yazen Ghannam <yazen.ghannam@....com>
> [...] 
> It's okay if Intel CPUs run this code, because they don't support these
> features. The feature flags are generally derived from CPUID bits, and
> x86 vendors do try to make sure they are unique and not
> overloaded/redefined between vendors.
>
> The same is true in reverse. It's okay if AMD CPUs run code to check for Intel-
> specific features. The feature checks will be false, and feature-specific code
> will not be used.

Thanks for addressing my concerns. 
This patch looks good to me.

    Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>