linux-kernel - Re: [PATCH 0/2] rdma: Converge on using secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfd711f3-2de6-44d0-afe9-e24470448011@linux.microsoft.com>
Date: Thu, 20 Feb 2025 08:17:31 -0800
From: Easwar Hariharan <eahariha@...ux.microsoft.com>
To: Leon Romanovsky <leon@...nel.org>
Cc: eahariha@...ux.microsoft.com, Yishai Hadas <yishaih@...dia.com>,
 Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] rdma: Converge on using secs_to_jiffies()

On 2/19/2025 11:07 PM, Leon Romanovsky wrote:
> On Wed, Feb 19, 2025 at 09:36:38PM +0000, Easwar Hariharan wrote:
>> This series converts users of msecs_to_jiffies() that either use the
>> multiply pattern of either of:
>> - msecs_to_jiffies(N*1000) or
>> - msecs_to_jiffies(N*MSEC_PER_SEC)
>>
>> where N is a constant or an expression, to avoid the multiplication.
> 
> Can you please provide justification for that? What is wrong with current code?
> 

There is nothing specifically wrong with the current code, it just does an unnecessary
multiplication for what it does, as the cover letter mentions. IMHO, it's also more readable
to just see secs_to_jiffies(30) and understand that it's a 30 second timeout.

Thanks,
Easwar (he/him)