linux-kernel - Re: [PATCH v3] cpupower: monitor: Exit with error status if execvp() fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <929c1d63-e3e7-432c-b34a-8953662297ab@linuxfoundation.org>
Date: Thu, 20 Feb 2025 10:37:31 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Yiwei Lin <s921975628@...il.com>, trenn@...e.com, shuah@...nel.org
Cc: jwyatt@...hat.com, jkacur@...hat.com, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] cpupower: monitor: Exit with error status if execvp()
 fail

On 2/20/25 09:38, Yiwei Lin wrote:
> In the case that we give a invalid command to idle_monitor for
> monitoring, the execvp() will fail and thus go to the next line.
> As a result, we'll see two differnt monitoring output. For
> example, running `cpupower monitor -i 5 invalidcmd` which `invalidcmd`
> is not executable.
> 
> ---

Note that everything below this gets thrown away.

> V3:
> - Modify output message content
> 
> V2:
> - Check return value from execvp and print message for invalid command
> ---

These version information goes after the --- below the Signed-off-by

Note that everything below the

> 
> Signed-off-by: Yiwei Lin <s921975628@...il.com>
> ---

This where the patch version stuff goes. I fixed this for now.

thanks,
-- Shuah