linux-kernel - Re: [PATCH v3] cpupower: monitor: Exit with error status if execvp() fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0c8505e-ceb4-4a82-8c3c-8043ee2ce256@gmail.com>
Date: Fri, 21 Feb 2025 01:46:29 +0800
From: Yiwei Lin <s921975628@...il.com>
To: Shuah Khan <skhan@...uxfoundation.org>, trenn@...e.com, shuah@...nel.org
Cc: jwyatt@...hat.com, jkacur@...hat.com, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] cpupower: monitor: Exit with error status if execvp()
 fail


On 2/21/2025 1:37 AM, Shuah Khan wrote:
> On 2/20/25 09:38, Yiwei Lin wrote:
>> In the case that we give a invalid command to idle_monitor for
>> monitoring, the execvp() will fail and thus go to the next line.
>> As a result, we'll see two differnt monitoring output. For
>> example, running `cpupower monitor -i 5 invalidcmd` which `invalidcmd`
>> is not executable.
>>
>> ---
>
> Note that everything below this gets thrown away.
>
>> V3:
>> - Modify output message content
>>
>> V2:
>> - Check return value from execvp and print message for invalid command
>> ---
>
> These version information goes after the --- below the Signed-off-by
>
> Note that everything below the
>
>>
>> Signed-off-by: Yiwei Lin <s921975628@...il.com>
>> ---
>
> This where the patch version stuff goes. I fixed this for now.
>
Thank you to help for the fix! I'll be careful with the commit message 
next time. I'm sorry if you experienced any inconvenience with this.

All the best,

Yiwei Lin