linux-kernel - Re: [PATCH] Alpha: Emulate unaligned LDx_L/STx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2502201951510.65342@angie.orcam.me.uk>
Date: Thu, 20 Feb 2025 19:57:56 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Matt Turner <mattst88@...il.com>
cc: Richard Henderson <richard.henderson@...aro.org>, 
    Ivan Kokshaysky <ink@...een.parts>, Arnd Bergmann <arnd@...db.de>, 
    John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>, 
    Magnus Lindholm <linmag7@...il.com>, 
    "Paul E. McKenney" <paulmck@...nel.org>, 
    Linus Torvalds <torvalds@...ux-foundation.org>, 
    Al Viro <viro@...iv.linux.org.uk>, linux-alpha@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Alpha: Emulate unaligned LDx_L/STx_C for data
 consistency

On Thu, 20 Feb 2025, Matt Turner wrote:

> > On Wed, Feb 19, 2025 at 7:46 AM Maciej W. Rozycki <macro@...am.me.uk> wrote:
> > >  #define OP_INT_MASK    ( 1L << 0x28 | 1L << 0x2c   /* ldl stl */       \
> > > +                       | 1L << 0x2a | 1L << 0x2e   /* ldl_l stl_c */   \
> > >                         | 1L << 0x29 | 1L << 0x2d   /* ldq stq */       \
> > > +                       | 1L << 0x2b | 1L << 0x2f   /* ldq_l stq_c */   \
> > >                         | 1L << 0x0c | 1L << 0x0d   /* ldwu stw */      \
> > >                         | 1L << 0x0a | 1L << 0x0e ) /* ldbu stb */
> > >
> > >  #define OP_WRITE_MASK  ( 1L << 0x26 | 1L << 0x27   /* sts stt */       \
> > >                         | 1L << 0x2c | 1L << 0x2d   /* stl stq */       \
> > > +                       | 1L << 0x2e | 1L << 0x2d   /* stl_c stq_c */   \
> >
> > stq_c should be 0x2f, not 0x2d. Looks like a copy-n-paste mistake.
> 
> The good news is that OP_WRITE_MASK appears to be unused going all the
> way back to the import into git, so this doesn't indicate a problem
> with any of the testing that's been done.

 Good catch, thank you, and I guess the lack of use is why things haven't 
broken.  I'll make a preparatory change in v2 and remove this macro then.

 FWIW it came with 2.1.36, already unused, so presumably a leftover from a 
WIP version.

 I'll fix the typo in the description as well, thank you.

  Maciej