linux-kernel - Re: [PATCH] objtool: Add bch2_trans_unlocked_or_in_restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <uhf4menbsgtgpyrsuwsipv56xgm6kbklsqgx5p3lfxfbkv43v4@7yjp4slw5dma>
Date: Thu, 20 Feb 2025 18:22:37 -0500
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Youling Tang <youling.tang@...ux.dev>
Cc: Josh Poimboeuf <jpoimboe@...nel.org>, 
	Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org, linux-bcachefs@...r.kernel.org, 
	k2ci <kernel-bot@...inos.cn>, Youling Tang <tangyouling@...inos.cn>
Subject: Re: [PATCH] objtool: Add bch2_trans_unlocked_or_in_restart_error()
 to bcachefs noreturns

On Tue, Feb 18, 2025 at 02:42:30PM +0800, Youling Tang wrote:
> From: Youling Tang <tangyouling@...inos.cn>
> 
> Fix the following objtool warning during build time:
> fs/bcachefs/btree_cache.o: warning: objtool: btree_node_lock.constprop.0() falls through to next function bch2_recalc_btree_reserve()
> fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function need_whiteout_for_snapshot()
> 
> bch2_trans_unlocked_or_in_restart_error() is an Obviously Correct (tm)
> panic() wrapper, add it to the list of known noreturns.
> 
> Fixes: b318882022a8 ("bcachefs: bch2_trans_verify_not_unlocked_or_in_restart()")
> Reported-by: k2ci<kernel-bot@...inos.cn>
> Signed-off-by: Youling Tang <tangyouling@...inos.cn>

Reviewed-by: Kent Overstreet <kent.overstreet@...ux.dev>

> ---
>  tools/objtool/noreturns.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/objtool/noreturns.h b/tools/objtool/noreturns.h
> index b2174894f9f7..6bb7edda3094 100644
> --- a/tools/objtool/noreturns.h
> +++ b/tools/objtool/noreturns.h
> @@ -19,7 +19,7 @@ NORETURN(__x64_sys_exit_group)
>  NORETURN(arch_cpu_idle_dead)
>  NORETURN(bch2_trans_in_restart_error)
>  NORETURN(bch2_trans_restart_error)
> -NORETURN(bch2_trans_unlocked_error)
> +NORETURN(bch2_trans_unlocked_or_in_restart_error)
>  NORETURN(cpu_bringup_and_idle)
>  NORETURN(cpu_startup_entry)
>  NORETURN(do_exit)
> -- 
> 2.34.1
>