linux-kernel - Re: [PATCH v2 0/3] media: add v4l2_subdev_state_xlate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tw6x663t5dmxsdarrxjtopza3mou3lnhwazu3dfv2k27fv47v2@bvftfepqqhss>
Date: Thu, 20 Feb 2025 12:38:15 +0100
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, 
	Mauro Carvalho Chehab <mchehab@...nel.org>, Julien Massot <julien.massot@...labora.com>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, Bingbu Cao <bingbu.cao@...el.com>, 
	Tianshu Qiu <tian.shu.qiu@...el.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, 
	Hans Verkuil <hverkuil@...all.nl>, Umang Jain <umang.jain@...asonboard.com>, 
	Paweł Anikiel <panikiel@...gle.com>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 0/3] media: add v4l2_subdev_state_xlate_streams()

Hi Cosmin

On Thu, Feb 20, 2025 at 11:20:32AM +0200, Cosmin Tanislav wrote:
> Currently, the v4l2_subdev_state_xlate_streams() function is used
> to translate streams from one pad to another.
> This function takes the entire subdev state as argument, but only makes
> use of the routing.

Correct, but is this a problem ?

Is this the first step for a larger rework or is this a drive-by
beautification ?

I'm asking because (and I know it's hard to strike a balance) this
kind of changes tend to make back-porting a more painful, and if
only justified by "it looks better" I would be a bit hesitant in
taking them.


>
> Introduce a v4l2_subdev_routing_xlate_streams() function which can be
> used without the entire subdev state, to avoid passing the entire state
> around when not needed.
>
> Convert all usages of v4l2_subdev_state_xlate_streams() to
> v4l2_subdev_routing_xlate_streams().
>
> Remove v4l2_subdev_state_xlate_streams().
>
> V2:
>   * Fix description of parameters
>
> Cosmin Tanislav (3):
>   media: v4l: subdev: add v4l2_subdev_routing_xlate_streams()
>   media: use v4l2_subdev_routing_xlate_streams()
>   media: v4l: subdev: remove v4l2_subdev_state_xlate_streams()
>
>  drivers/media/i2c/ds90ub913.c                 | 14 ++++++-----
>  drivers/media/i2c/ds90ub953.c                 | 14 ++++++-----
>  drivers/media/i2c/max96714.c                  | 16 ++++++-------
>  drivers/media/i2c/max96717.c                  | 23 ++++++++++---------
>  drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c | 14 ++++++-----
>  .../platform/nxp/imx8-isi/imx8-isi-crossbar.c |  2 +-
>  drivers/media/v4l2-core/v4l2-subdev.c         |  7 +++---
>  include/media/v4l2-subdev.h                   | 10 ++++----
>  8 files changed, 53 insertions(+), 47 deletions(-)
>
> --
> 2.48.1
>
>