linux-kernel - Re: [net-next PATCH v10 5/6] octeontx2-af: CN20K mbox implementation for AF's VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d35d5b44-e0a4-4d07-8199-dfc916962c39@redhat.com>
Date: Thu, 20 Feb 2025 13:06:12 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Sai Krishna <saikrishnag@...vell.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, sgoutham@...vell.com, gakula@...vell.com,
 lcherian@...vell.com, jerinj@...vell.com, hkelam@...vell.com,
 sbhatta@...vell.com, andrew+netdev@...n.ch,
 kalesh-anakkur.purayil@...adcom.com
Subject: Re: [net-next PATCH v10 5/6] octeontx2-af: CN20K mbox implementation
 for AF's VF

On 2/17/25 9:52 AM, Sai Krishna wrote:
> @@ -61,3 +62,49 @@ irqreturn_t cn20k_pfaf_mbox_intr_handler(int irq, void *pf_irq)
>  
>  	return IRQ_HANDLED;
>  }
> +
> +irqreturn_t cn20k_vfaf_mbox_intr_handler(int irq, void *vf_irq)
> +{
> +	struct otx2_nic *vf = vf_irq;
> +	struct otx2_mbox_dev *mdev;
> +	struct otx2_mbox *mbox;
> +	struct mbox_hdr *hdr;
> +	int vf_trig_val;
> +
> +	vf_trig_val = otx2_read64(vf, RVU_VF_INT) & 0x3;
> +	/* Clear the IRQ */
> +	otx2_write64(vf, RVU_VF_INT, vf_trig_val);
> +
> +	/* Read latest mbox data */
> +	smp_rmb();
> +
> +	if (vf_trig_val & BIT_ULL(1)) {

`vf_trig_val` has `int` type, why are casting the mask to unsigned long
long? A similar thing below.

/P