linux-kernel - Re: [net-next PATCH v10 5/6] octeontx2-af: CN20K mbox implementation for AF's VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA1PR18MB47090327591A59698DAAD39BA0C12@SA1PR18MB4709.namprd18.prod.outlook.com>
Date: Sun, 23 Feb 2025 14:40:55 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: Paolo Abeni <pabeni@...hat.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Linu Cherian
	<lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
        Hariprasad Kelam
	<hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "kalesh-anakkur.purayil@...adcom.com" <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [net-next PATCH v10 5/6] octeontx2-af: CN20K mbox implementation
 for AF's VF


> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> Sent: Thursday, February 20, 2025 5:36 PM
> To: Sai Krishna Gajula <saikrishnag@...vell.com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Sunil Kovvuri Goutham <sgoutham@...vell.com>;
> Geethasowjanya Akula <gakula@...vell.com>; Linu Cherian
> <lcherian@...vell.com>; Jerin Jacob <jerinj@...vell.com>; Hariprasad
> Kelam <hkelam@...vell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@...vell.com>; andrew+netdev@...n.ch; kalesh-
> anakkur.purayil@...adcom.com
> Subject: Re: [net-next PATCH v10 5/6] octeontx2-af: CN20K mbox
> implementation for AF's VF
> 
> On 2/17/25 9: 52 AM, Sai Krishna wrote: > @@ -61,3 +62,49 @@ irqreturn_t
> cn20k_pfaf_mbox_intr_handler(int irq, void *pf_irq) > > return
> IRQ_HANDLED; > } > + > +irqreturn_t cn20k_vfaf_mbox_intr_handler(int irq,
> void *vf_irq) 
> On 2/17/25 9:52 AM, Sai Krishna wrote:
> > @@ -61,3 +62,49 @@ irqreturn_t cn20k_pfaf_mbox_intr_handler(int irq,
> > void *pf_irq)
> >
> >  	return IRQ_HANDLED;
> >  }
> > +
> > +irqreturn_t cn20k_vfaf_mbox_intr_handler(int irq, void *vf_irq) {
> > +	struct otx2_nic *vf = vf_irq;
> > +	struct otx2_mbox_dev *mdev;
> > +	struct otx2_mbox *mbox;
> > +	struct mbox_hdr *hdr;
> > +	int vf_trig_val;
> > +
> > +	vf_trig_val = otx2_read64(vf, RVU_VF_INT) & 0x3;
> > +	/* Clear the IRQ */
> > +	otx2_write64(vf, RVU_VF_INT, vf_trig_val);
> > +
> > +	/* Read latest mbox data */
> > +	smp_rmb();
> > +
> > +	if (vf_trig_val & BIT_ULL(1)) {
> 
> `vf_trig_val` has `int` type, why are casting the mask to unsigned long long? A
> similar thing below.
Ack, will fix in V11 version. 
> 
> /P