linux-kernel - Re: [net-next PATCH v10 2/6] octeontx2-af: CN20k basic mbox operations and structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BY3PR18MB4707CCD4F93834C9408DAD64A0C32@BY3PR18MB4707.namprd18.prod.outlook.com>
Date: Tue, 25 Feb 2025 06:05:57 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: Paolo Abeni <pabeni@...hat.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Linu Cherian
	<lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
        Hariprasad Kelam
	<hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "kalesh-anakkur.purayil@...adcom.com" <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [net-next PATCH v10 2/6] octeontx2-af: CN20k basic mbox
 operations and structures

> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> Sent: Thursday, February 20, 2025 5:20 PM
> To: Sai Krishna Gajula <saikrishnag@...vell.com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Sunil Kovvuri Goutham <sgoutham@...vell.com>;
> Geethasowjanya Akula <gakula@...vell.com>; Linu Cherian
> <lcherian@...vell.com>; Jerin Jacob <jerinj@...vell.com>; Hariprasad Kelam
> <hkelam@...vell.com>; Subbaraya Sundeep Bhatta <sbhatta@...vell.com>;
> andrew+netdev@...n.ch; kalesh-anakkur.purayil@...adcom.com
> Subject: Re: [net-next PATCH v10 2/6] octeontx2-af: CN20k basic
> mbox operations and structures
> 
> On 2/17/25 9: 52 AM, Sai Krishna wrote: > @@ -2443,6 +2469,18 @@ static
> int rvu_mbox_init(struct rvu *rvu, struct mbox_wq_info *mw, > } > } > > +
> ng_rvu_mbox = kzalloc(sizeof(*ng_rvu_mbox), GFP_KERNEL); > + if
> (!ng_rvu_mbox) 
> On 2/17/25 9:52 AM, Sai Krishna wrote:
> > @@ -2443,6 +2469,18 @@ static int rvu_mbox_init(struct rvu *rvu, struct
> mbox_wq_info *mw,
> >  		}
> >  	}
> >
> > +	ng_rvu_mbox = kzalloc(sizeof(*ng_rvu_mbox), GFP_KERNEL);
> > +	if (!ng_rvu_mbox) {
> > +		err = -ENOMEM;
> > +		goto free_bitmap;
> > +	}
> > +
> > +	rvu->ng_rvu = ng_rvu_mbox
> 
> AFAICS rvu->ng_rvu is freed only by rvu_remove(), so it's leaked on the later
> error paths.
Ack, will submit v11 with updates.
> 
> /P