linux-kernel - Re: [PATCH v2 1/3] drm/amdgpu: Log the creation of a coredump file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_P_+QCeAnxZzf_N6+EgzLM9iUs-XxDaoNYkEzJAO26UGA@mail.gmail.com>
Date: Fri, 21 Feb 2025 09:58:59 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: André Almeida <andrealmeid@...lia.com>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	Xinhui Pan <Xinhui.Pan@....com>, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	kernel-dev@...lia.com, siqueira@...lia.com
Subject: Re: [PATCH v2 1/3] drm/amdgpu: Log the creation of a coredump file

Applied, thanks!

Alex

On Thu, Feb 20, 2025 at 11:28 AM André Almeida <andrealmeid@...lia.com> wrote:
>
> After a GPU reset happens, the driver creates a coredump file. However,
> the user might not be aware of it. Log the file creation the user can
> find more information about the device and add the file to bug reports.
> This is similar to what the xe driver does.
>
> Reviewed-by: Christian König <christian.koenig@....com>
> Signed-off-by: André Almeida <andrealmeid@...lia.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> index 824f9da5b6ce..7b50741dc097 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c
> @@ -364,5 +364,9 @@ void amdgpu_coredump(struct amdgpu_device *adev, bool skip_vram_check,
>
>         dev_coredumpm(dev->dev, THIS_MODULE, coredump, 0, GFP_NOWAIT,
>                       amdgpu_devcoredump_read, amdgpu_devcoredump_free);
> +
> +       drm_info(dev, "AMDGPU device coredump file has been created\n");
> +       drm_info(dev, "Check your /sys/class/drm/card%d/device/devcoredump/data\n",
> +                dev->primary->index);
>  }
>  #endif
> --
> 2.48.1
>