linux-kernel - Re: [PATCH v2 2/3] drm/amdgpu: Log after a successful ring reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_O9NnvVObz5BPr4rx0RpWXY-2UWmY0tw=7WhnzG4khf7g@mail.gmail.com>
Date: Fri, 21 Feb 2025 10:08:47 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: André Almeida <andrealmeid@...lia.com>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	Xinhui Pan <Xinhui.Pan@....com>, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	kernel-dev@...lia.com, siqueira@...lia.com
Subject: Re: [PATCH v2 2/3] drm/amdgpu: Log after a successful ring reset

Applied.  Thanks!

On Thu, Feb 20, 2025 at 11:28 AM André Almeida <andrealmeid@...lia.com> wrote:
>
> When a ring reset happens, the kernel log shows only "amdgpu: Starting
> <ring name> ring reset", but when it finishes nothing appears in the
> log. Explicitly write in the log that the reset has finished correctly.
>
> Reviewed-by: Christian König <christian.koenig@....com>
> Signed-off-by: André Almeida <andrealmeid@...lia.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 100f04475943..698e5799e542 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -149,6 +149,7 @@ static enum drm_gpu_sched_stat amdgpu_job_timedout(struct drm_sched_job *s_job)
>                         amdgpu_fence_driver_force_completion(ring);
>                         if (amdgpu_ring_sched_ready(ring))
>                                 drm_sched_start(&ring->sched, 0);
> +                       dev_err(adev->dev, "Ring %s reset succeeded\n", ring->sched.name);
>                         goto exit;
>                 }
>                 dev_err(adev->dev, "Ring %s reset failure\n", ring->sched.name);
> --
> 2.48.1
>