linux-kernel - Re: [PATCH net-next v10 05/13] net: ip_tunnel: Don't set tunnel->net in ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250221032629.73823-1-kuniyu@amazon.com>
Date: Thu, 20 Feb 2025 19:26:29 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <shaw.leon@...il.com>
CC: <alex.aring@...il.com>, <andrew+netdev@...n.ch>,
	<b.a.t.m.a.n@...ts.open-mesh.org>, <bpf@...r.kernel.org>,
	<bridge@...ts.linux.dev>, <davem@...emloft.net>, <donald.hunter@...il.com>,
	<dsahern@...nel.org>, <edumazet@...gle.com>, <herbert@...dor.apana.org.au>,
	<horms@...nel.org>, <kuba@...nel.org>, <kuniyu@...zon.com>,
	<linux-can@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <linux-ppp@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
	<linux-wpan@...r.kernel.org>, <miquel.raynal@...tlin.com>,
	<netdev@...r.kernel.org>, <osmocom-net-gprs@...ts.osmocom.org>,
	<pabeni@...hat.com>, <shuah@...nel.org>, <stefan@...enfreihafen.org>,
	<steffen.klassert@...unet.com>, <wireguard@...ts.zx2c4.com>
Subject: Re: [PATCH net-next v10 05/13] net: ip_tunnel: Don't set tunnel->net in ip_tunnel_init()

From: Xiao Liang <shaw.leon@...il.com>
Date: Wed, 19 Feb 2025 20:50:31 +0800
> ip_tunnel_init() is called from register_netdevice(). In all code paths
> reaching here, tunnel->net should already have been set (either in
> ip_tunnel_newlink() or __ip_tunnel_create()). So don't set it again.
> 
> Signed-off-by: Xiao Liang <shaw.leon@...il.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>