linux-kernel - Re: [PATCH v2 2/3] devres: Add devm_is_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc426e67-106d-4b0f-b4ec-f8fbf089770e@quicinc.com>
Date: Fri, 21 Feb 2025 11:34:35 +0800
From: Zijun Hu <quic_zijuhu@...cinc.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>,
        Raag Jadav <raag.jadav@...el.com>, <linux-kernel@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>
CC: "Rafael J. Wysocki" <rafael@...nel.org>,
        Danilo Krummrich
	<dakr@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz
 Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v2 2/3] devres: Add devm_is_action_added() helper

On 2/21/2025 12:20 AM, Andy Shevchenko wrote:
> In some code we would like to know if the action in device managed resources
> was added by devm_add_action() family of calls. Introduce a helper for that.
> 
> Reviewed-by: Raag Jadav <raag.jadav@...el.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/base/devres.c         | 11 +++++++++++
>  include/linux/device/devres.h |  2 ++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> index 93e7779ef21e..7c2babfa9396 100644
> --- a/drivers/base/devres.c
> +++ b/drivers/base/devres.c
> @@ -749,6 +749,17 @@ int __devm_add_action(struct device *dev, void (*action)(void *), void *data, co
>  }
>  EXPORT_SYMBOL_GPL(__devm_add_action);
>  
> +bool devm_is_action_added(struct device *dev, void (*action)(void *), void *data)
> +{
> +	struct action_devres devres = {
> +		.data = data,
> +		.action = action,
> +	};
> +
> +	return devres_find(dev, devm_action_release, devm_action_match, &devres);
> +}
> +EXPORT_SYMBOL_GPL(devm_is_action_added);
> +
>  /**
>   * devm_remove_action_nowarn() - removes previously added custom action
>   * @dev: Device that owns the action
> diff --git a/include/linux/device/devres.h b/include/linux/device/devres.h
> index 9cd1787ef28e..ae696d10faff 100644
> --- a/include/linux/device/devres.h
> +++ b/include/linux/device/devres.h
> @@ -165,4 +165,6 @@ static inline int __devm_add_action_or_reset(struct device *dev, void (*action)(
>  #define devm_add_action_or_reset(dev, action, data) \
>  	__devm_add_action_or_reset(dev, action, data, #action)
>  
> +bool devm_is_action_added(struct device *dev, void (*action)(void *), void *data);
> +
>  #endif /* _DEVICE_DEVRES_H_ */

Reviewed-by: Zijun Hu <quic_zijuhu@...cinc.com>