linux-kernel - Re: [PATCH] crypto: inside-secure: eip93: Correctly handle return of for sg_nents_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7hGs9rzgceurzWo@gondor.apana.org.au>
Date: Fri, 21 Feb 2025 17:26:11 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Antoine Tenart <atenart@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Richard van Schagen <vschagen@...oud.com>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH] crypto: inside-secure: eip93: Correctly handle return of
 for sg_nents_for_len

On Sun, Feb 16, 2025 at 12:36:18AM +0100, Christian Marangi wrote:
> Fix smatch warning for sg_nents_for_len return value in Inside Secure
> EIP93 driver.
> 
> The return value of sg_nents_for_len was assigned to an u32 and the
> error was ignored and converted to a positive integer.
> 
> Rework the code to correctly handle the error from sg_nents_for_len to
> mute smatch warning.
> 
> Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  .../crypto/inside-secure/eip93/eip93-common.c | 25 ++++++++++++++-----
>  1 file changed, 19 insertions(+), 6 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt