linux-kernel - Re: [PATCH 00/12] badblocks: bugfix and cleanup for badblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <t6fbzky7xgffr7ftst747jsircm2uhucbhpbhnn56ewwq2j2gj@a7ctlr2gigyj>
Date: Fri, 21 Feb 2025 19:52:16 +0800
From: Coly Li <colyli@...nel.org>
To: Zheng Qixing <zhengqixing@...weicloud.com>
Cc: axboe@...nel.dk, song@...nel.org, yukuai3@...wei.com, 
	dan.j.williams@...el.com, vishal.l.verma@...el.com, dave.jiang@...el.com, 
	ira.weiny@...el.com, dlemoal@...nel.org, yanjun.zhu@...ux.dev, kch@...dia.com, 
	hare@...e.de, zhengqixing@...wei.com, john.g.garry@...cle.com, 
	geliang@...nel.org, xni@...hat.com, colyli@...e.de, linux-block@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org, nvdimm@...ts.linux.dev, 
	yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH 00/12] badblocks: bugfix and cleanup for badblocks

On Fri, Feb 21, 2025 at 04:10:57PM +0800, Zheng Qixing wrote:
> From: Zheng Qixing <zhengqixing@...wei.com>
> 
> During RAID feature implementation testing, we found several bugs
> in badblocks.
> 
> This series contains bugfixes and cleanups for MD RAID badblocks
> handling code.
> 
> Li Nan (8):
>   badblocks: Fix error shitf ops
>   badblocks: factor out a helper try_adjacent_combine
>   badblocks: attempt to merge adjacent badblocks during
>     ack_all_badblocks
>   badblocks: return error directly when setting badblocks exceeds 512
>   badblocks: return error if any badblock set fails
>   badblocks: fix the using of MAX_BADBLOCKS
>   badblocks: try can_merge_front before overlap_front
>   badblocks: fix merge issue when new badblocks align with pre+1
> 
> Zheng Qixing (4):
>   badblocks: fix missing bad blocks on retry in _badblocks_check()
>   badblocks: return boolen from badblocks_set() and badblocks_clear()
>   md: improve return types of badblocks handling functions
>   badblocks: use sector_t instead of int to avoid truncation of
>     badblocks length
>

Thank you all for the testing and fix up!

Coly Li

 
>  block/badblocks.c             | 317 +++++++++++++---------------------
>  drivers/block/null_blk/main.c |  19 +-
>  drivers/md/md.c               |  47 +++--
>  drivers/md/md.h               |  14 +-
>  drivers/md/raid1-10.c         |   2 +-
>  drivers/md/raid1.c            |  10 +-
>  drivers/md/raid10.c           |  14 +-
>  drivers/nvdimm/badrange.c     |   2 +-
>  drivers/nvdimm/nd.h           |   2 +-
>  drivers/nvdimm/pfn_devs.c     |   7 +-
>  drivers/nvdimm/pmem.c         |   2 +-
>  include/linux/badblocks.h     |  10 +-
>  12 files changed, 181 insertions(+), 265 deletions(-)
> 
> -- 
> 2.39.2
>