linux-kernel - Re: [PATCH] rust: workqueue: define built-in bh queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7lPcy6mgOVSFhZr@kernel.org>
Date: Sat, 22 Feb 2025 06:15:47 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Hamza Mahfooz <hamzamahfooz@...ux.microsoft.com>
Cc: rust-for-linux@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Wedson Almeida Filho <walmeida@...rosoft.com>,
	Nell Shamrell-Harrington <nells@...ux.microsoft.com>,
	Dirk Behme <dirk.behme@...il.com>,
	Konstantin Andrikopoulos <kernel@...dragore.io>,
	Danilo Krummrich <dakr@...nel.org>,
	Roland Xu <mu001999@...look.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: workqueue: define built-in bh queues

On Fri, Feb 21, 2025 at 05:35:31PM -0500, Hamza Mahfooz wrote:
> We provide these methods because it lets us access these queues from
> Rust without using unsafe code.
> 
> Signed-off-by: Hamza Mahfooz <hamzamahfooz@...ux.microsoft.com>

Just getting familiar how code testing and reviews go with Rust code,
as I might put out even a driver at some point of time, so let's give
this a shot :-)

Using 1st person plural is usually almost a cardinal sin almost and is
somewhat exhausting to read. "These methods" refer to nothing and the
commit message does not educate me why the accessors are needed.

It should be IMHO language agnostic that commit message is more
important than the source code. It weights now even more than ever
before because it is also AI acid test. The current commit message
is as good as it did not exist at all.

Based on these conclusions I'd start the commit message by saying
that "Provide safe accessors to the workqueue bottom-halves."

Then add another sentence on why they are required (i.e. who will
be  the caller for these).

BR, Jarkko