linux-kernel - Re: [PATCH] rust: workqueue: define built-in bh queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7lVeWFX-8uQJaJC@Mac.home>
Date: Fri, 21 Feb 2025 20:41:29 -0800
From: Boqun Feng <boqun.feng@...il.com>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
	Hamza Mahfooz <hamzamahfooz@...ux.microsoft.com>,
	Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>,
	rust-for-linux@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Wedson Almeida Filho <walmeida@...rosoft.com>,
	Nell Shamrell-Harrington <nells@...ux.microsoft.com>,
	Dirk Behme <dirk.behme@...il.com>,
	Konstantin Andrikopoulos <kernel@...dragore.io>,
	Danilo Krummrich <dakr@...nel.org>,
	Roland Xu <mu001999@...look.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: workqueue: define built-in bh queues

On Sat, Feb 22, 2025 at 06:37:06AM +0200, Jarkko Sakkinen wrote:
> On Sat, Feb 22, 2025 at 06:17:41AM +0200, Jarkko Sakkinen wrote:
> > On Fri, Feb 21, 2025 at 11:45:38PM +0100, Miguel Ojeda wrote:
> > > On Fri, Feb 21, 2025 at 11:36 PM Hamza Mahfooz
> > > <hamzamahfooz@...ux.microsoft.com> wrote:
> > > >
> > > > We provide these methods because it lets us access these queues from
> > > > Rust without using unsafe code.
> > > >
> > > > Signed-off-by: Hamza Mahfooz <hamzamahfooz@...ux.microsoft.com>
> > > 
> > > Cc'ing WORKQUEUE -- thanks!
> > 
> > Not meaning to complain but it by practical has no commit message.
> 
> oops, sorry, "... but by practical means it ..."
> 
> Anyway I hope my message was received ;-) Leaves me wonder tho why
> this was queued because it apparently is not even part of a patch

What do you mean by "queued"? IIUC, Miguel was just copying workqueue
maintainers, since they should be in the review process.

Thanks for your review in another email anyway!

Regards,
Boqun

> set. "zero callers" should never be merged to mainline...
> 
> If however such patch is merged, the commit message should probably
> address this exceptional condition.
> 
> R, Jarkko