linux-kernel - Re: [PATCH] rust: workqueue: define built-in bh queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9b783dff11a923b53cb654a843af7ae33478f30.camel@kernel.org>
Date: Sat, 22 Feb 2025 08:04:19 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Boqun Feng <boqun.feng@...il.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Hamza Mahfooz	
 <hamzamahfooz@...ux.microsoft.com>, Tejun Heo <tj@...nel.org>, Lai
 Jiangshan	 <jiangshanlai@...il.com>, rust-for-linux@...r.kernel.org, Miguel
 Ojeda	 <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Gary Guo	
 <gary@...yguo.net>, Björn Roy Baron	
 <bjorn3_gh@...tonmail.com>, Benno Lossin <benno.lossin@...ton.me>, Andreas
 Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, Trevor
 Gross <tmgross@...ch.edu>,  Wedson Almeida Filho <walmeida@...rosoft.com>,
 Nell Shamrell-Harrington <nells@...ux.microsoft.com>, Dirk Behme	
 <dirk.behme@...il.com>, Konstantin Andrikopoulos <kernel@...dragore.io>, 
 Danilo Krummrich	 <dakr@...nel.org>, Roland Xu <mu001999@...look.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: workqueue: define built-in bh queues

On Fri, 2025-02-21 at 20:41 -0800, Boqun Feng wrote:
> On Sat, Feb 22, 2025 at 06:37:06AM +0200, Jarkko Sakkinen wrote:
> > On Sat, Feb 22, 2025 at 06:17:41AM +0200, Jarkko Sakkinen wrote:
> > > On Fri, Feb 21, 2025 at 11:45:38PM +0100, Miguel Ojeda wrote:
> > > > On Fri, Feb 21, 2025 at 11:36 PM Hamza Mahfooz
> > > > <hamzamahfooz@...ux.microsoft.com> wrote:
> > > > > 
> > > > > We provide these methods because it lets us access these
> > > > > queues from
> > > > > Rust without using unsafe code.
> > > > > 
> > > > > Signed-off-by: Hamza Mahfooz
> > > > > <hamzamahfooz@...ux.microsoft.com>
> > > > 
> > > > Cc'ing WORKQUEUE -- thanks!
> > > 
> > > Not meaning to complain but it by practical has no commit
> > > message.
> > 
> > oops, sorry, "... but by practical means it ..."
> > 
> > Anyway I hope my message was received ;-) Leaves me wonder tho why
> > this was queued because it apparently is not even part of a patch
> 
> What do you mean by "queued"? IIUC, Miguel was just copying workqueue
> maintainers, since they should be in the review process.
> 
> Thanks for your review in another email anyway!

Ah sorry! I have dyslexia (for real) and I did read that the patch
was queued :-) Thanks for correcting and please do also the next
time!

I spent also last 48h awake setting up my personal Rust development
and QA environment... [1]

Anyway, to soften my feedback a bit I'll say this: everything else was
great:

1. Code was great
2. It was commented like you'd expect.

And I don't have much to complain about code quality in any other
patches I've seen so far.

I've been silently following this list for some time and this is a
common problem that the commit messages are quite bad. Thus, I even
wrote a public post about the topic now that I had this in mind:

https://social.kernel.org/notice/ArMk27Ism4Citb90K0

There's two great arguments to improve across the board:

1. Education
2. Integrity. E.g. AI is actually acceptable for short a patch, if
   you can in detail unmask the implementation (as is e.g. Windows
   notepad or really anything that produces text). But AI can be also
   used to engineer harmless looking changes that are actually vulns.
   By being punctual in expalanations we also contribute to the 
   governance of our ecosystem.

I'm personally reading this list exactly for learning purposes because I
have a roadmap to Rust driver ongoing, and explanations even in trivial
things help to gather bits and pieces... So please help me to succeed
by doing just a tiny bit more effort ;-)

> Regards,
> Boqun

[1] https://codeberg.org/jarkko/linux-tpmdd-nixos

BR, Jarkko