linux-kernel - Re: [PATCH bpf-next v3 5/9] arm64: insn: Add BIT(23) to {load,store}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02ef4695-c9d6-4867-a25a-7d9e617f9c48@huaweicloud.com>
Date: Sat, 22 Feb 2025 17:28:56 +0800
From: Xu Kuohai <xukuohai@...weicloud.com>
To: Peilin Ye <yepeilin@...gle.com>, bpf@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Cc: bpf@...f.org, Eduard Zingerman <eddyz87@...il.com>,
 David Vernet <void@...ifault.com>, Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Jonathan Corbet <corbet@....net>,
 "Paul E. McKenney" <paulmck@...nel.org>, Puranjay Mohan
 <puranjay@...nel.org>, Ilya Leoshkevich <iii@...ux.ibm.com>,
 Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Quentin Monnet <qmo@...nel.org>, Mykola Lysenko <mykolal@...com>,
 Shuah Khan <shuah@...nel.org>, Ihor Solodrai <ihor.solodrai@...ux.dev>,
 Yingchi Long <longyingchi24s@....ac.cn>, Josh Don <joshdon@...gle.com>,
 Barret Rhoden <brho@...gle.com>, Neel Natu <neelnatu@...gle.com>,
 Benjamin Segall <bsegall@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v3 5/9] arm64: insn: Add BIT(23) to
 {load,store}_ex's mask

On 2/20/2025 9:21 AM, Peilin Ye wrote:
> We are planning to add load-acquire (LDAR{,B,H}) and store-release
> (STLR{,B,H}) instructions to insn.{c,h}; add BIT(23) to mask of load_ex
> and store_ex to prevent aarch64_insn_is_{load,store}_ex() from returning
> false-positives for load-acquire and store-release instructions.
> 
> Reference: Arm Architecture Reference Manual (ARM DDI 0487K.a,
>             ID032224),
> 
>    * C6.2.228 LDXR
>    * C6.2.165 LDAXR
>    * C6.2.161 LDAR
>    * C6.2.393 STXR
>    * C6.2.360 STLXR
>    * C6.2.353 STLR
> 
> Signed-off-by: Peilin Ye <yepeilin@...gle.com>
> ---
>   arch/arm64/include/asm/insn.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/insn.h b/arch/arm64/include/asm/insn.h
> index e390c432f546..2d8316b3abaf 100644
> --- a/arch/arm64/include/asm/insn.h
> +++ b/arch/arm64/include/asm/insn.h
> @@ -351,8 +351,8 @@ __AARCH64_INSN_FUNCS(ldr_imm,	0x3FC00000, 0x39400000)
>   __AARCH64_INSN_FUNCS(ldr_lit,	0xBF000000, 0x18000000)
>   __AARCH64_INSN_FUNCS(ldrsw_lit,	0xFF000000, 0x98000000)
>   __AARCH64_INSN_FUNCS(exclusive,	0x3F800000, 0x08000000)
> -__AARCH64_INSN_FUNCS(load_ex,	0x3F400000, 0x08400000)
> -__AARCH64_INSN_FUNCS(store_ex,	0x3F400000, 0x08000000)
> +__AARCH64_INSN_FUNCS(load_ex,	0x3FC00000, 0x08400000)
> +__AARCH64_INSN_FUNCS(store_ex,	0x3FC00000, 0x08000000)
>   __AARCH64_INSN_FUNCS(mops,	0x3B200C00, 0x19000400)
>   __AARCH64_INSN_FUNCS(stp,	0x7FC00000, 0x29000000)
>   __AARCH64_INSN_FUNCS(ldp,	0x7FC00000, 0x29400000)

Looks good to me

Acked-by: Xu Kuohai <xukuohai@...wei.com>