[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3b540c87-1d55-4289-b347-6bc2da49f407@163.com>
Date: Sun, 23 Feb 2025 13:30:48 +0800
From: Hans Zhang <18255117159@....com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: jingoohan1@...il.com, shradha.t@...sung.com, lpieralisi@...nel.org,
kw@...ux.com, robh@...nel.org, bhelgaas@...gle.com, Frank.Li@....com,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
rockswang7@...il.com, Niklas Cassel <cassel@...nel.org>
Subject: Re: [v4] PCI: dwc: Add the debugfs property to provide the LTSSM
status of the PCIe link
On 2025/2/23 00:39, Manivannan Sadhasivam wrote:
>> +
>> +What: /sys/kernel/debug/dwc_pcie_<dev>/ltssm_status
>> +Date: February 2025
>> +Contact: Hans Zhang <18255117159@....com>
>> +Description: (RO) Read will return the current value of the PCIe link status raw value and
>> + string status.
>
> 'Read will return the current PCIe LTSSM state in both string and raw value.'
>
>>
>> +char *dw_ltssm_sts_string(enum dw_pcie_ltssm ltssm)
>
> const char *dw_pcie_ltssm_string()
>
>> +{
>> + char *str;
>
> const char *
>
>> +
>> + switch (ltssm) {
>> +#define DW_PCIE_LTSSM_NAME(n) case n: str = #n; break
>> @@ -683,6 +714,8 @@ static inline enum dw_pcie_ltssm dw_pcie_get_ltssm(struct dw_pcie *pci)
>> return (enum dw_pcie_ltssm)FIELD_GET(PORT_LOGIC_LTSSM_STATE_MASK, val);
>> }
>>
>> +char *dw_ltssm_sts_string(enum dw_pcie_ltssm ltssm);
>
> const char *dw_pcie_ltssm_string()
These recommendations will be changed in the next version.
Thank you very much Mani.
Best regards
Hans
Powered by blists - more mailing lists