linux-kernel - Re: [PATCH net-next v5 07/12] net: ethtool: Add PSE new budget evaluation strategy support feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250224141351.3a942099@kmaincent-XPS-13-7390>
Date: Mon, 24 Feb 2025 14:13:51 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Donald Hunter
 <donald.hunter@...il.com>, Rob Herring <robh@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
 Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime
 Chevallier <maxime.chevallier@...tlin.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 07/12] net: ethtool: Add PSE new budget
 evaluation strategy support feature

On Fri, 21 Feb 2025 14:49:21 +0100
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> Hi Kory,
> 
> On Tue, Feb 18, 2025 at 05:19:11PM +0100, Kory Maincent wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> > 
> > This patch expands the status information provided by ethtool for PSE c33
> > with current port priority and max port priority. It also adds a call to
> > pse_ethtool_set_prio() to configure the PSE port priority.  
> 
> Thank you! Here are some comments...
> 
> > --- a/Documentation/networking/ethtool-netlink.rst
> > +++ b/Documentation/networking/ethtool-netlink.rst
> > @@ -1790,6 +1790,12 @@ Kernel response contents:
> >    ``ETHTOOL_A_C33_PSE_PW_LIMIT_RANGES``       nested  Supported power limit
> >                                                        configuration ranges.
> >    ``ETHTOOL_A_PSE_PW_D_ID``                      u32  Index of the PSE
> > power domain
> > +  ``ETHTOOL_A_C33_PSE_BUDGET_EVAL_STRAT``        u32  Budget evaluation
> > strategy
> > +                                                      of the PSE
> > +  ``ETHTOOL_A_C33_PSE_PRIO_MAX``                 u32  Priority maximum
> > configurable
> > +                                                      on the PoE PSE
> > +  ``ETHTOOL_A_C33_PSE_PRIO``                     u32  Priority of the PoE
> > PSE
> > +                                                      currently configured
> >  
> 
> Please remove _C33_ from these fields, as they are not specific to Clause 33.

Oops, forgot to update the documentation accordingly. Thanks for spotting it.

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com