linux-kernel - Re: [PATCH net-next v5 09/12] net: pse-pd: pd692x0: Add support for controller and manager power supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250224141716.01751dc4@fedora>
Date: Mon, 24 Feb 2025 14:17:16 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Kory Maincent <kory.maincent@...tlin.com>, Andrew Lunn <andrew@...n.ch>,
 Oleksij Rempel <o.rempel@...gutronix.de>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, Donald Hunter <donald.hunter@...il.com>, Rob Herring
 <robh@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman
 <horms@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
 Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 09/12] net: pse-pd: pd692x0: Add support for
 controller and manager power supplies

On Mon, 24 Feb 2025 12:49:19 +0000
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> On Mon, Feb 24, 2025 at 01:42:22PM +0100, Maxime Chevallier wrote:
> > On Tue, 18 Feb 2025 17:19:13 +0100
> > Kory Maincent <kory.maincent@...tlin.com> wrote:  
> > > diff --git a/drivers/net/pse-pd/pd692x0.c b/drivers/net/pse-pd/pd692x0.c
> > > index 44ded2aa6fca..c9fa60b314ce 100644
> > > --- a/drivers/net/pse-pd/pd692x0.c
> > > +++ b/drivers/net/pse-pd/pd692x0.c
> > > @@ -976,8 +976,10 @@ pd692x0_register_managers_regulator(struct pd692x0_priv *priv,
> > >  	reg_name_len = strlen(dev_name(dev)) + 23;
> > >  
> > >  	for (i = 0; i < nmanagers; i++) {
> > > +		static const char * const regulators[] = { "vaux5", "vaux3p3" };  
> > 
> > Looks like the 'static' is not needed here :)  
> 
> Have you checked the compiler output before saying that?

No I have not

> I've seen plenty of instances where "static" should be there but isn't,
> leading to the compiler generating inline code to create the
> array/struct on the stack.

Makes sense then, so it should be good here.

Thanks,

Maxime