linux-kernel - Re: [PATCH net-next v5 02/12] net: pse-pd: Add support for reporting events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250224191917.31063062@kmaincent-XPS-13-7390>
Date: Mon, 24 Feb 2025 19:19:17 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Donald Hunter
 <donald.hunter@...il.com>, Rob Herring <robh@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
 Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime
 Chevallier <maxime.chevallier@...tlin.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 02/12] net: pse-pd: Add support for
 reporting events

On Mon, 24 Feb 2025 12:02:28 +0100
Kory Maincent <kory.maincent@...tlin.com> wrote:

> Hello Oleksij,
> 
> On Fri, 21 Feb 2025 09:50:33 +0100
> Oleksij Rempel <o.rempel@...gutronix.de> wrote:
> 
> > Hi Kory,
> > 
> > On Tue, Feb 18, 2025 at 05:19:06PM +0100, Kory Maincent wrote:  
> > > From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> > > 
> > > Add support for devm_pse_irq_helper() to register PSE interrupts. This
> > > aims to report events such as over-current or over-temperature conditions
> > > similarly to how the regulator API handles them but using a specific PSE
> > > ethtool netlink socket.    
> > 
> > Thank you for your work. Here some comments.
> > 
> > ...
> >   
> > > --- a/drivers/net/mdio/fwnode_mdio.c
> > > +++ b/drivers/net/mdio/fwnode_mdio.c
> > > @@ -18,7 +18,8 @@ MODULE_LICENSE("GPL");
> > >  MODULE_DESCRIPTION("FWNODE MDIO bus (Ethernet PHY) accessors");
> > >  
> > >  static struct pse_control *
> > > -fwnode_find_pse_control(struct fwnode_handle *fwnode)
> > > +fwnode_find_pse_control(struct fwnode_handle *fwnode,
> > > +			struct phy_device *phydev)
> > >  {    
> > 
> > This change seems to be not directly related to the commit message.
> > Is it the preparation for the multi-phy support?  
> 
> I need to save the phy_device related to PSE control to use the right network
> interface for the ethtool notification. (ethnl_pse_send_ntf())
> Indeed I have not described this in the commit message.

In fact, there is another solution. We can go over all the PHYs and look for
the one that matches the psec pointer.

Mmh it is maybe better, it will avoid saving the phy_device pointer into
the newly attached_phydev.

I will go for it in v6.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com