linux-kernel - Re: [PATCH v2] auxdisplay: hd44780: Fix an API misuse in hd44780.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVYxruwpA92FykyEAwoSBxfb0Z1AmnyqLziGTpMC3d_gg@mail.gmail.com>
Date: Mon, 24 Feb 2025 14:33:49 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Andy Shevchenko <andy@...nel.org>
Cc: Haoxiang Li <haoxiang_li2024@....com>, u.kleine-koenig@...gutronix.de, 
	erick.archer@...look.com, ojeda@...nel.org, w@....eu, poeschel@...onage.de, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] auxdisplay: hd44780: Fix an API misuse in hd44780.c

Hi Andy,

On Mon, 24 Feb 2025 at 13:35, Andy Shevchenko <andy@...nel.org> wrote:
> On Mon, Feb 24, 2025 at 06:15:27PM +0800, Haoxiang Li wrote:
> > Variable allocated by charlcd_alloc() should be released
> > by charlcd_free(). The following patch changed kfree() to
> > charlcd_free() to fix an API misuse.
>
> > Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
> > Cc: stable@...r.kernel.org
>
> Okay, looking closer to the current state of affairs, the change
> does not fix anything actually. OTOH it's correct semantically and
> allows to do any further development in charlcd_alloc(), if any.
>
> That said, if Geert is okay with it, I would like to apply but without
> Fixes/Cc: stable@ tags.

I had mixed feelings about the Fixes-tag, too.
Semantically, it's indeed a fix.  If any further cleanups are ever done
and backported, but this patch would be  missed, it would introduce a bug.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds