linux-kernel - Re: [PATCH v2] auxdisplay: hd44780: Fix an API misuse in hd44780.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7x2UFoTsLR0umvH@smile.fi.intel.com>
Date: Mon, 24 Feb 2025 15:38:24 +0200
From: Andy Shevchenko <andy@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Haoxiang Li <haoxiang_li2024@....com>, u.kleine-koenig@...gutronix.de,
	erick.archer@...look.com, ojeda@...nel.org, w@....eu,
	poeschel@...onage.de, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] auxdisplay: hd44780: Fix an API misuse in hd44780.c

On Mon, Feb 24, 2025 at 02:33:49PM +0100, Geert Uytterhoeven wrote:
> On Mon, 24 Feb 2025 at 13:35, Andy Shevchenko <andy@...nel.org> wrote:
> > On Mon, Feb 24, 2025 at 06:15:27PM +0800, Haoxiang Li wrote:
> > > Variable allocated by charlcd_alloc() should be released
> > > by charlcd_free(). The following patch changed kfree() to
> > > charlcd_free() to fix an API misuse.
> >
> > > Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
> > > Cc: stable@...r.kernel.org
> >
> > Okay, looking closer to the current state of affairs, the change
> > does not fix anything actually. OTOH it's correct semantically and
> > allows to do any further development in charlcd_alloc(), if any.
> >
> > That said, if Geert is okay with it, I would like to apply but without
> > Fixes/Cc: stable@ tags.
> 
> I had mixed feelings about the Fixes-tag, too.
> Semantically, it's indeed a fix.  If any further cleanups are ever done
> and backported, but this patch would be  missed, it would introduce a bug.

Okay, I return it.

-- 
With Best Regards,
Andy Shevchenko