linux-kernel - Re: [PATCH net-next 0/2] net: phy: sfp: Add single-byte SMBus SFP access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c6b7b3f-04a2-48ce-b3a9-2ea71041c6d2@lunn.ch>
Date: Mon, 24 Feb 2025 04:32:29 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Bjørn Mork <bjorn@...k.no>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	davem@...emloft.net, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
	Florian Fainelli <f.fainelli@...il.com>,
	Köry Maincent <kory.maincent@...tlin.com>,
	Simon Horman <horms@...nel.org>,
	Romain Gantois <romain.gantois@...tlin.com>,
	Antoine Tenart <atenart@...nel.org>,
	Marek Behún <kabel@...nel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: sfp: Add single-byte SMBus SFP
 access

> So, not only do I think that hwmon should be disabled if using SMBus,
> but I also think that the kernel should print a warning that SMBus is
> being used and therefore e.g. copper modules will be unreliable. We
> don't know how the various firmwares in various microprocessors that
> convert I2C to MDIO will behave when faced with SMBus transfers.

I agree, hwmon should be disabled, and that the kernel should printing
a warning that the hardware is broken and that networking is not
guaranteed to be reliable.

	Andrew