linux-kernel - Re: [PATCH v6 00/14] Add eDP support for RK3588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <731abf8f-b157-47d4-a9e1-9aed6f5b4e37@rock-chips.com>
Date: Mon, 24 Feb 2025 11:21:02 +0800
From: Damon Ding <damon.ding@...k-chips.com>
To: Piotr Oniszczuk <piotr.oniszczuk@...il.com>,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: heiko@...ech.de, robh@...nel.org, conor+dt@...nel.org,
 algea.cao@...k-chips.com, rfoss@...nel.org, devicetree@...r.kernel.org,
 linux-phy@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 hjc@...k-chips.com, kever.yang@...k-chips.com, dmitry.baryshkov@...aro.org,
 vkoul@...nel.org, andy.yan@...k-chips.com, krzk+dt@...nel.org,
 linux-arm-kernel@...ts.infradead.org, l.stach@...gutronix.de
Subject: Re: [PATCH v6 00/14] Add eDP support for RK3588

Hi Piotr,

On 2025/2/14 20:00, Piotr Oniszczuk wrote:
> 
> 
>> Wiadomość napisana przez Sebastian Reichel <sebastian.reichel@...labora.com> w dniu 13 lut 2025, o godz. 18:26:
>>
>> Hello Piotr,
>>
>>
>> The RK3588 has two different DP controllers. The one handled in this
>> series should get the eDP port running, which is routed to the
>> "eDP Panel" in the block diagram on page 3 of the Rock 5 ITX schematics.
>> So this series adds support for using "HDMI/eDP TX0" and "HDMI/eDP TX1"
>> in DP mode.
>>
>> The port routed to HDMI0 via RA620 is the other DP controller, which
>> also exists twice: "TYPEC0/DP0" and "TYPEC1/DP1". This DP controller
>> is not yet supported upstream and there is no pending patchset. As far
>> as I know Rockchip plans to work on preparing upstream support for that
>> soon.

Yes, Andy has recently updated the DP controller related patchset:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=936784

>>
> 
> Oh - this is very valuable info and explains a lot.
> Thx.
> 
>> Note, that the two DisplayPort controllers are completely different.
>> The HDMI/eDP controller is a design from Analogix and the TypeC/DP
>> controller is a design from Synopsys.
>>
>> P.S.: Heiko merged support for HDMI1 (RK3588 SoC level) recently. So you
>> should be able to get that running by some DT additions to the Rock 5
>> ITX board DT with the latest linux-next code :)
>>
> 
> And it works perfectly on all my 3588 bards (including audio and my cec addition)
> But only on boards using both hdmi tx0 and tx1 to hdmi0/hdmi1 ports.
> 
> on rock5 itx:

According to the schematic of ROCK 5 ITX, I find the display routes are:
- DP0 -> TYPEC0 Connector
- DP1 -> RA620 -> HDMI Connector (Andy's patch series will help it work)
- HDMI/eDP TX0 -> eDP Panel (This patch series will help it work)
- HDMI/eDP TX1 -> HDMI Connector

So the HDMI/eDP TX0 should be enabled as eDP in DTS. Maybe it's just a 
test to enable both HDMI0 and HDMI1 in the ROCK 5 ITX board?

> With both hdmi tx0 and tx1 enabled in dts it looks like kernel detects hdmi tx0 as connected and tries read edid.
> As nothing is connected to J11 (eDP con) - i’m getting i2c ddc timeouts
> [   54.188880] dwhdmiqp-rockchip fde80000.hdmi: i2c read timed out
> [   54.292207] dwhdmiqp-rockchip fde80000.hdmi: i2c read timed out
> [   54.395554] dwhdmiqp-rockchip fde80000.hdmi: i2c read timed out
> 

I think the reason may be that HDMI0 is enabled, and HPD pin of HDMI0 is 
also configured, but the HPD pin is in an unstable state in the 
hardware, which is mistakenly detected as connected.

> 
> disabling hdmi0 makes kernel talking to hdmi1 but with issues:
> [    0.540446] dwhdmiqp-rockchip fdea0000.hdmi: registered DesignWare HDMI QP I2C bus driver
> [    0.541230] rockchip-drm display-subsystem: bound fdea0000.hdmi (ops dw_hdmi_qp_rockchip_ops)
> [    0.542285] [drm] Initialized rockchip 1.0.0 for display-subsystem on minor 0
> [    0.542933] rockchip-drm display-subsystem: [drm] Cannot find any crtc or sizes
> [    0.543605] rockchip-drm display-subsystem: [drm] Cannot find any crtc or sizes
> 
> and here i’m a bit puzzled as on other 3588 boards (i.e. rock5b) - when i connected monitor to hdmi1 - all works perfectly
> (kernel, OS and app nicely skipping hdmi0 and talking to actually connected hdmi1 port. all works)
> 
> on rock5 itx this not works.
> 
> my observations so far are:
> -on rock5 itx hdmi0 is falsely detected as connected - even when eDP connector (J11) has nothing connected
> -on rock5 itx disabling hdmi0 in dts breaks hdmi1
> -on other 3588 (e.g. rock 5b) disabling hdmi0 in dts NOT breaks hdmi1
> 
> strange….
> 
> 

Best regards
Damon