linux-kernel - Re: [PATCH] RDMA/core: fix a NULL-pointer dereference in hw_stat_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250224151127.GT50639@nvidia.com>
Date: Mon, 24 Feb 2025 11:11:27 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Parav Pandit <parav@...lanox.com>
Cc: Roman Gushchin <roman.gushchin@...ux.dev>,
	Leon Romanovsky <leon@...nel.org>,
	Maher Sanalla <msanalla@...dia.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RDMA/core: fix a NULL-pointer dereference in
 hw_stat_device_show()

On Sat, Feb 22, 2025 at 06:34:21PM +0000, Parav Pandit wrote:
> ib_setup_device_attrs() should be merged to ib_setup_port_attrs() by
> renaming ib_setup_port_attrs() to be generic.  To utilize the group
> initialization ib_setup_port_attrs() needs to move up before
> device_add().

It needs more than that, somehow you have to maintain two groups list
or somehow remove the coredev->dev.groups assignment..

Jason